Skip to content

Deal with multiple image hashes.#23

Merged
marqh merged 3 commits intomarqh:check_graphic_hashfrom
bjlittle:check-graphic-with-multi-hashes
Oct 5, 2016
Merged

Deal with multiple image hashes.#23
marqh merged 3 commits intomarqh:check_graphic_hashfrom
bjlittle:check-graphic-with-multi-hashes

Conversation

@bjlittle
Copy link

@bjlittle bjlittle commented Oct 5, 2016

No description provided.

@marqh
Copy link
Owner

marqh commented Oct 5, 2016

@bjlittle it would be great to have one example of having two hashes for one test in the collection, to see this behaviour in action and test the test resource test

cheers
mark

@bjlittle
Copy link
Author

bjlittle commented Oct 5, 2016

@marqh Targeted the failing test iris.tests.test_analysis.TestRotatedPole.test_all.2 which had the original hash https://scitools.github.io/test-images-scitools/image_files/0f5c99da44a0f4640374961907f324a5dac767eb.png

Added the new and additional hash https://scitools.github.io/test-images-scitools/image_files/6b5e42fc27c146b1e5e6b6e57b7d4dce0891463b.png

This new resource has not been added to the test-images-scitools repo, which should exercise your new test ...

@bjlittle
Copy link
Author

bjlittle commented Oct 5, 2016

@marqh ping ...

@marqh
Copy link
Owner

marqh commented Oct 5, 2016

ok, this is looking good, a couple of minor issues with py3 which i'm fixing now

merging....

@marqh marqh merged commit eb2e7b7 into marqh:check_graphic_hash Oct 5, 2016
@bjlittle bjlittle deleted the check-graphic-with-multi-hashes branch October 13, 2016 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants