Skip to content

Fbopt matchduva#641

Merged
smilesun merged 10 commits intofboptfrom
fbopt_matchduva
Nov 22, 2023
Merged

Fbopt matchduva#641
smilesun merged 10 commits intofboptfrom
fbopt_matchduva

Conversation

@smilesun
Copy link
Copy Markdown
Collaborator

No description provided.

@smilesun smilesun changed the base branch from master to fbopt November 16, 2023 16:30
@smilesun
Copy link
Copy Markdown
Collaborator Author

It looks like the only useful change is in a_model_classif.y

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (03cdb2e) 92.88% compared to head (634861d) 92.83%.

Files Patch % Lines
domainlab/models/model_wrapper_matchdg4vae.py 50.00% 2 Missing ⚠️
domainlab/models/a_model_classif.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            fbopt     #641      +/-   ##
==========================================
- Coverage   92.88%   92.83%   -0.05%     
==========================================
  Files         138      138              
  Lines        5410     5416       +6     
==========================================
+ Hits         5025     5028       +3     
- Misses        385      388       +3     
Flag Coverage Δ
unittests 92.83% <57.14%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilesun smilesun merged commit af67865 into fbopt Nov 22, 2023
@smilesun smilesun deleted the fbopt_matchduva branch November 22, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants