Skip to content

issue 754 fix#765

Merged
smilesun merged 1 commit intofboptfrom
issue_754
Jan 24, 2024
Merged

issue 754 fix#765
smilesun merged 1 commit intofboptfrom
issue_754

Conversation

@agisga
Copy link
Copy Markdown
Collaborator

@agisga agisga commented Jan 23, 2024

Attempt to address #754

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: 98 lines in your changes are missing coverage. Please review.

Comparison is base (154ac0b) 92.85% compared to head (486d81a) 92.80%.
Report is 656 commits behind head on fbopt.

Files Patch % Lines
domainlab/utils/generate_fbopt_phase_portrait.py 0.00% 40 Missing ⚠️
domainlab/algos/trainers/compos/matchdg_match.py 87.23% 6 Missing ⚠️
domainlab/algos/trainers/train_matchdg.py 95.20% 6 Missing ⚠️
domainlab/algos/trainers/train_fbopt_b.py 83.33% 3 Missing ⚠️
domainlab/models/model_erm.py 83.33% 3 Missing ⚠️
domainlab/algos/builder_custom.py 87.50% 2 Missing ⚠️
domainlab/algos/trainers/fbopt_mu_controller.py 92.85% 2 Missing ⚠️
domainlab/algos/trainers/fbopt_setpoint_ada.py 90.00% 2 Missing ⚠️
domainlab/algos/trainers/zoo_trainer.py 87.50% 2 Missing ⚠️
domainlab/cli.py 85.71% 2 Missing ⚠️
... and 23 more
Additional details and impacted files
@@            Coverage Diff             @@
##            fbopt     #765      +/-   ##
==========================================
- Coverage   92.85%   92.80%   -0.05%     
==========================================
  Files         136      134       -2     
  Lines        5400     5521     +121     
==========================================
+ Hits         5014     5124     +110     
- Misses        386      397      +11     
Flag Coverage Δ
unittests 92.80% <93.67%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants