Skip to content

Logging epochs#796

Merged
smilesun merged 7 commits intomasterfrom
logging-epochs
Mar 27, 2024
Merged

Logging epochs#796
smilesun merged 7 commits intomasterfrom
logging-epochs

Conversation

@MatteoWohlrapp
Copy link
Copy Markdown
Collaborator

Added functionality to add the epoch when the model was selected to the results file.

…he results file. Integrated in the model selection process
…eady contained in the dictionary beeing passed to the writer
@MatteoWohlrapp MatteoWohlrapp linked an issue Mar 22, 2024 that may be closed by this pull request
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 95.13%. Comparing base (3a3e3b9) to head (d5c03c8).

Files Patch % Lines
domainlab/algos/msels/a_model_sel.py 91.66% 1 Missing ⚠️
domainlab/algos/msels/c_msel_val.py 50.00% 1 Missing ⚠️
domainlab/algos/observers/b_obvisitor.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   95.16%   95.13%   -0.03%     
==========================================
  Files         127      127              
  Lines        5002     5015      +13     
==========================================
+ Hits         4760     4771      +11     
- Misses        242      244       +2     
Flag Coverage Δ
unittests 95.13% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@smilesun
Copy link
Copy Markdown
Collaborator

could you fix the codacy as well?

As a general rule, we do not have to fix those coday issues which requires too much time, but for empty space trailing etc we should fix them

@smilesun smilesun merged commit 9663aad into master Mar 27, 2024
@smilesun smilesun deleted the logging-epochs branch March 27, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

log the epoch number when the model is selected

3 participants