Merged
Conversation
Collaborator
|
Collaborator
Author
|
When did you get this output? |
Collaborator
i just copied the CI log, maybe it gives you a hint what went wrong. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #821 +/- ##
=======================================
Coverage 95.17% 95.17%
=======================================
Files 128 128
Lines 5080 5080
=======================================
Hits 4835 4835
Misses 245 245
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Collaborator
I just added a wildcard to the benchmark results folder in the CI script, hopefuly it can fix the issue |
smilesun
requested changes
May 13, 2024
run_benchmark_slurm.sh
Outdated
| export DOMAINLAB_CUDA_START_SEED=$2 | ||
| fi | ||
|
|
||
| # Extract output_dir from the YAML configuration file |
Collaborator
There was a problem hiding this comment.
could you put the common bash operations into a function in a separate script in scripts folder?
Collaborator
CI passed now |
…/DomainLab into benchmark_results_suffix
Collaborator
|
I clicked two times rerun the CI, but it looks like it did not re-run |
added 2 commits
June 25, 2024 18:30
Collaborator
|
still the same error with poetry NameError: name 'extend' is not defined @agisga , do you have any idea what is going on? |
Collaborator
|
@smilesun I just looked through the commit history of DomId, and I had solved an issue that seems to be the same error with "name 'extend' is not defined"! What worked for me was adding the following to pyproject.toml: There seems to be a compatibility bug between backpack and newer versions of setuptools (70.x). Hope that helps! |
Collaborator
|
Collaborator
|
Collaborator
|
I tried sometime to fix the seborn problem above: currently, matplotlib==3.8.2 ; python_version >= "3.9" and python_version < "4.0" and seaborn==0.12.2 ; python_version >= "3.9" and python_version < "4.0" in the requirements.txt, but i could not reproduce the error on my laptop after chaning the version of matplotlib and seaborn, any idea @MatteoWohlrapp @agisga |
Collaborator
|
the error occurs at rule: |
Collaborator
|
smilesun
reviewed
Jul 2, 2024
smilesun
requested changes
Jul 2, 2024
… seed and added comments to the utils function for the benchmark script
Collaborator
@MatteoWohlrapp @agisga , I FIXED it, in fact, the unit test is run with the poetry dependencies, instead of requirements.txt, i have updated pyproj.yaml and now the unit test passed for seaborn and matplotlib |
smilesun
approved these changes
Jul 2, 2024
Collaborator
smilesun
left a comment
smilesun
left a comment
There was a problem hiding this comment.
Thanks for the nice work @MatteoWohlrapp , i will now test it on the cluster if the benchmark works as expected.
Collaborator
It works on the cluster! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added time when the benchmark script was executed as a suffix. For that, I am getting the folder name from the configuration file and extending this name with the timestamp, then adding it to the snakemake command to overwrite the existing output folder path. See format below:
