Add golden tests that illustrate parsing results#3
Draft
andrewthad wants to merge 1 commit intomarseillebd:masterfrom
Draft
Add golden tests that illustrate parsing results#3andrewthad wants to merge 1 commit intomarseillebd:masterfrom
andrewthad wants to merge 1 commit intomarseillebd:masterfrom
Conversation
Collaborator
|
Only double-quoted strings allow templating. The single-quote strings are there specifically so that the only escaping that needs to be done is for single-quotes. |
889d33f to
2847e18
Compare
Contributor
Author
|
Thanks, I had missed that. I've done a force push correcting the test. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a simple integration test that serves two purposes:
pretty-showand dropping all location annotations results in output that is at least somewhat readable. It would be better to manually write a pretty printer for the expression type, but that's more difficult to do.Concerning goal (2), I have a concern. I'm trying to use a string template in the input file, but the parser does not seem to understand what I've done:
I expected that
yearswould be broken apart from the other stuff, but I might just be using string templates incorrectly.