Fix ChainedConfigurationProvider.Load() to propagate reload to inner IConfigurationRoot#6
Closed
Fix ChainedConfigurationProvider.Load() to propagate reload to inner IConfigurationRoot#6
Conversation
…IConfigurationRoot Co-authored-by: martincostello <1439341+martincostello@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with runtime behavior as described in #58683
Fix ChainedConfigurationProvider.Load() to propagate reload to inner IConfigurationRoot
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChainedConfigurationProvider.Load()was a no-op, so callingIConfigurationRoot.Reload()on a chained configuration never reloaded the inner root's providers — values stayed stale after an explicit reload.Description
ChainedConfigurationProvider.Load(): now callsReload()on the inner configuration when it implementsIConfigurationRoot; remains a no-op for plainIConfigurationwrappers.ChainedConfiguration_ReloadPropagatestoInnerConfigurationRoot— verifies that a value produced by an inner provider changes afterouterConfig.Reload().Side-effect to be aware of: an explicit
Reload()on the outer root fires its change token twice — once when the inner reload propagates up through the already-registeredChangeToken.OnChangelistener, and once from the outerReload()'s ownRaiseChanged(). This is consistent with how automatic (file-watcher) reloads already propagate through chains and is not a data-correctness issue.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
pe4vsblobprodcus351.vsblob.vsassets.io/home/REDACTED/work/runtime/runtime/.dotnet/dotnet dotnet build(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.