_updateMaxLineLength() can be called before 001#286
Closed
bcome wants to merge 1 commit intomartynsmith:masterfrom
Closed
_updateMaxLineLength() can be called before 001#286bcome wants to merge 1 commit intomartynsmith:masterfrom
bcome wants to merge 1 commit intomartynsmith:masterfrom
Conversation
Collaborator
|
It may be better to default the hostmask to an empty string for any other places that assume it's type. |
ghost
changed the title
|
The semantics here are:
A separate, unrelated issue discovered while troubleshooting this is that many ircds do not send a meaningful hostname as part of their 001, so we'll need to think of a proper way of handling that. |
bcome
force-pushed
the
fixUpdateMaxLineLength
branch
from
562f794 to
fd3c919
Compare
This was referenced Jan 11, 2015
Closed
ghost
pushed a commit
that referenced
this pull request
Jan 11, 2015
Set self.hostMask to the empty string to elegantly solve #286
|
Per @jirwin's suggestion, I implemented this as an empty string assignment. |
ghost
closed this
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix _updateMaxLineLength() to not crash when this.hostMask is not set yet.