Revert "Add option to train TE MLP layers only"#8
Merged
maruo555 merged 1 commit intomaruo-mainfrom May 23, 2025
Merged
Conversation
This reverts commit 76aa64c.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #5
バグっていたので元に戻す
--te_mlp_fc_only 指定時の動作が期待通りでない
TEXT_ENCODER_TARGET_REPLACE_MODULEを書き換えるタイミングが遅くて
学習は Attention もするけど保存はしないみたいになっていそう