Skip to content

Comments

Signin highos#150

Closed
ghost wants to merge 13 commits intomasterfrom
signin-highos
Closed

Signin highos#150
ghost wants to merge 13 commits intomasterfrom
signin-highos

Conversation

@ghost
Copy link

@ghost ghost commented Jul 1, 2018

No description provided.

@ldgmini
Copy link

ldgmini commented Jul 1, 2018

1 Error
🚫 📝 Please provide a summary in the Pull Request description
1 Warning
⚠️ 😵 Big PR

Generated by 🚫 Danger

@phatblat
Copy link
Member

phatblat commented Jul 1, 2018

@PatYo9 the signin-highos branch is not ready to be merged. The main issue I've been hoping to resolve is the signin functionality. The method accountService.signIn(with: context) worked in older versions of macOS, but was removed in High Sierra (10.13) and I have not been able to find an alternative.

Since this is part of a private framework, it is not supported by Apple, which limits our options.

@ghost
Copy link
Author

ghost commented Jul 1, 2018 via email

@todo
Copy link

todo bot commented Aug 11, 2018

Handle failed AppleID lookup

// TODO: Handle failed AppleID lookup
print("No account found for username: \(username)")
}
group.leave()
}


This comment was generated by todo based on a TODO comment in 76b1098 in #150. cc @mas-cli.

@phatblat phatblat closed this Aug 11, 2018
@todo todo bot mentioned this pull request Aug 11, 2018
@phatblat
Copy link
Member

phatblat commented Aug 11, 2018

Superceded by #162

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants