Merged
Conversation
Potential solution to #226
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting on macOS 10.14.4,
mas listis not displaying app names. It displays the id and version correctly, but app name is missing. This affects the display when usingbrew bundle, but doesn't appear to affect functionality.macOS 10.14.3
Using mas 1.6.2, this is how an app is displayed on 10.14.3.
macOS 10.14.4
mas 1.6.2
This PR
The fix in this change is to fall back to
bundleIdentifierwhenappNameis blank.appNamevalues. This shouldn't be a problem as it is only used for display in bothmas listandbrew bundle.Also resolves #226, some confusion when using the
brew bundlecommand (which relies onmas list).