Skip to content

Code refactor, linting, formatting...#2

Draft
MicaelJarniac wants to merge 7 commits intomaschere:mainfrom
MicaelJarniac:refactor-template
Draft

Code refactor, linting, formatting...#2
MicaelJarniac wants to merge 7 commits intomaschere:mainfrom
MicaelJarniac:refactor-template

Conversation

@MicaelJarniac
Copy link
Copy Markdown

I've been loving the game so far, and decided to give it a go at refactoring the code here.

I understand these might be too many changes to review, and a lot of it is very opinionated, so feel free to reject the PR.

If you do like it, though, and would like me to change something, feel free to ask.

It's WIP for now, so I'll create the PR as a draft.

@maschere
Copy link
Copy Markdown
Owner

maschere commented Jan 5, 2025

Hi Micael, thanks for your interest in the project and the work on this PR. I won't be merging any PRs in the next weeks until JOY 1.0 is out and any critical issues fixed.

Now this PR are a lot of changes, and I'm not entirely sure if I want to completely refactor and restructure the pyjop code.

@MicaelJarniac
Copy link
Copy Markdown
Author

Hi Micael, thanks for your interest in the project and the work on this PR. I won't be merging any PRs in the next weeks until JOY 1.0 is out and any critical issues fixed.

Now this PR are a lot of changes, and I'm not entirely sure if I want to completely refactor and restructure the pyjop code.

No worries. I'm having as much fun working on this code as playing the game. I think I'll keep working on it for myself, and if you see anything you could use, just let me know.

I'm trying to keep the API unchanged, mostly just fixing typing errors. I'm also trying to write tests for the codebase.

I plan on trying to make my own interface based on this one, but with API changes, async stuff, and such, but that's just an idea for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants