Support for empty strings in translation files.#261
Merged
mashpie merged 1 commit intomashpie:masterfrom Oct 23, 2019
Merged
Conversation
…replaced by their key.
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I currently have a use-case where I need to have an empty string in my translation file. Currently, i18n-node will replace this translation with the key, as it thinks that the translation does not exist. Here's an example:
Used like so;
Currently, this is output like so (with group name X):
English:
Add to <strong>X</strong> groupFrench:
Ajouter au groupe <strong>X</strong> AddToGroup.2because i18n-node will replace the empty string for
AddToGroup.2in French with the keyAddToGroup.2.This pull request fixes that by only replacing with the key if the translation key does not exist, rather than being empty string (was a basic falsey check where it should've been a check for null/undefined).
Also added some tests for this use case.