Some improvements#395
Merged
mashpie merged 9 commits intomashpie:masterfrom Apr 16, 2019
Merged
Conversation
Contributor
Author
|
@mashpie It can be safely merged and released. 🤓 Note: If you need a maintainer, I'm in! |
Owner
|
...I fucked up notifications again. @rimiti Thanks a lot, super helpful and crucial to proceed with maintenance |
|
Appveyor may have served a purpose; it is usually run in a windows environment, whereas travis has to be configured to do so manually. It could be added to the travis config to run on Linux and Windows. more travis/windows references Here is one of the more recents build (~4 months ago), when appveyor ran successfully: https://ci.appveyor.com/project/mashpie/i18n-node/builds/20882799/job/4cn4bfkktkmcw397 |
This was referenced Apr 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Some improvements:
global(GLOBAL is deprecated).Regards, 🚀