Merged
Conversation
5 tasks
Thykof
previously requested changes
Aug 24, 2023
Contributor
Thykof
left a comment
Thykof
left a comment
There was a problem hiding this comment.
This is my partial review
Thykof
reviewed
Aug 24, 2023
qdrn
reviewed
Aug 25, 2023
Contributor
qdrn
left a comment
qdrn
left a comment
There was a problem hiding this comment.
I've read a large portion. Thanks for the good work.
One general comment is that I believe that the large introduction at the start could belong to it's own section. It would ease the reading I believe.
Side comment: didn't we agree to put things regarding Massa Station in it's own sidebar section ?
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Contributor
|
FYI we made a whole Massa Station section in #205. I think you will need to refactor a bit. |
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
Co-authored-by: Adrien LF <alf@massa.net>
qdrn
approved these changes
Oct 2, 2023
Contributor
Author
|
@qdrn I think this can be merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have drafted all the necessary steps for the tutorial to implement the hello-world MS plugins.
It is still missing a lot of context and explanation, but I wish to get reviewed upon the "logic" of the tutorial.
Feel free to elaborate your comments as I'm not so familiar with go, and I might have missed some important points.