Skip to content

add faucet doc#52

Merged
qdrn merged 5 commits intomainfrom
50-network-faucet-page
Jun 6, 2023
Merged

add faucet doc#52
qdrn merged 5 commits intomainfrom
50-network-faucet-page

Conversation

@lilyanB
Copy link
Contributor

@lilyanB lilyanB commented Jun 5, 2023

No description provided.

@lilyanB lilyanB linked an issue Jun 5, 2023 that may be closed by this pull request
@lilyanB lilyanB requested a review from 0xB19 June 5, 2023 17:50
@qdrn
Copy link
Contributor

qdrn commented Jun 5, 2023

I would put the faucet doc in the build section. As was decided here: https://github.com/massalabs/docu-dev/pull/29/files#diff-4d7e57f9b0d680e6756ea5f2117815ad177e0df673cf04cff626b4a34fd1ab11
The node section will quickly be outdated once the testnet is over with mainnet launch and we want to target developers.

@lilyanB lilyanB force-pushed the 50-network-faucet-page branch 2 times, most recently from 2df5c03 to e966502 Compare June 6, 2023 05:46
@lilyanB lilyanB requested a review from qdrn June 6, 2023 05:47
@lilyanB lilyanB force-pushed the 50-network-faucet-page branch from e966502 to 637342a Compare June 6, 2023 14:15
Copy link
Contributor

@qdrn qdrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made small changes and made a comment. There is also a conflict to solve. Otherwise it looks ok.

@lilyanB lilyanB force-pushed the 50-network-faucet-page branch from 56bbe3f to bb42cd9 Compare June 6, 2023 15:00
@lilyanB lilyanB force-pushed the 50-network-faucet-page branch from bb42cd9 to 6a9aef3 Compare June 6, 2023 15:03
@lilyanB lilyanB requested a review from qdrn June 6, 2023 15:06
@qdrn qdrn merged commit cd1457e into main Jun 6, 2023
@qdrn qdrn deleted the 50-network-faucet-page branch June 6, 2023 23:11
@qdrn
Copy link
Contributor

qdrn commented Jun 6, 2023

I've fixed the sidebar to follow #29. And made a small change to the intro phrase. Thanks for the work @lilyanB !

@lilyanB lilyanB removed the request for review from 0xB19 June 7, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

network-faucet page

2 participants