Merged
Conversation
Closed
qdrn
suggested changes
Jun 7, 2023
Contributor
qdrn
left a comment
qdrn
left a comment
There was a problem hiding this comment.
Any reason to use two different pages for faucets and networks contrary to what was decided in #29 ? I think most of the infos can be conveniently packed into a table.
Personally I would go for one page for faucet + networks with the following structure (to be adapted):
- brief description of what is inside the page
- explain difference between testnet and buildnet and emphasise that buildnet is what we support with our tooling (explain how it's done with sdks etc...)
- maybe some notes regarding specific things like faucets are on Discord and are limited to one request/day
- a table that provide: faucet, api, explorer link (maybe I'm missing things)
I would remove the introduction paragraphs that are good description but provide little added value.
Maybe you can discuss this briefly in the daily ?
lilyanB
force-pushed
the
59-networks-page
branch
2 times, most recently
from
506a30b to
339149f
Compare
Contributor
Author
|
thanks for your help @gregLibert |
gregLibert
approved these changes
Jun 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.