Pool LZ4 working buffers to reduce compression allocations#132
Open
Isusami wants to merge 1 commit intomasterking32:mainfrom
Open
Pool LZ4 working buffers to reduce compression allocations#132Isusami wants to merge 1 commit intomasterking32:mainfrom
Isusami wants to merge 1 commit intomasterking32:mainfrom
Conversation
Add lz4BufferPool with getLZ4Buffer/putLZ4Buffer to reuse scratch buffers across compress/decompress calls. Output is bytes.Clone'd to decouple from the pooled buffer before returning it to the pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
sync.Pool-backed scratch buffers for LZ4 compress/decompress to avoid allocating a fresh buffer on every call.Changes
lz4BufferPoolwithgetLZ4Buffer/putLZ4BuffercompressLZ4: use pooled buffer for compression output,bytes.Clonethe result before returning the buffer to the pooldecompressLZ4: use pooled buffer for decompression output,bytes.Clonethe result before returning the buffer to the poolWhy
LZ4 compress/decompress are called on every packet. Reusing scratch buffers reduces allocation pressure.
bytes.Cloneensures the returned slice is decoupled from the pool.Test plan
go test -race ./internal/compression/...-- all 4 tests pass, race-clean