Develop#1129
Open
Quelaan1 wants to merge 3 commits into
Open
Conversation
Quelaan1
commented
Sep 28, 2022
Quelaan1
commented
- DEMO LINK
added 2 commits
September 29, 2022 04:33
ghost
approved these changes
Oct 3, 2022
Comment on lines
7
to
19
| <Sum | ||
| a={2} | ||
| b={3} | ||
| /> | ||
| <Sum | ||
| a={-5} | ||
| b={5} | ||
| /> | ||
| <Sum a={10} /> | ||
| <Sum b={5} /> | ||
| <Sum /> | ||
| </> | ||
| ); |
There was a problem hiding this comment.
Just a note, unlike with raw HTML, in React linter allows up to 3 attributes per line, so no need for newlines here
ihor-jpeg
suggested changes
Oct 7, 2022
Comment on lines
+7
to
+14
| <Sum | ||
| a={2} | ||
| b={3} | ||
| /> | ||
| <Sum | ||
| a={-5} | ||
| b={5} | ||
| /> |
| import React from 'react'; | ||
|
|
||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p>{`Sum of ${a} and ${b} is ${a + b}`}</p> |
There was a problem hiding this comment.
Suggested change
| <p>{`Sum of ${a} and ${b} is ${a + b}`}</p> | |
| <p> | |
| {`Sum of ${a} and ${b} is ${a + b}`} | |
| </p> |
ihor-jpeg
approved these changes
Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.