Skip to content

Added task solution#3834

Open
nikitachupahin wants to merge 2 commits into
mate-academy:masterfrom
nikitachupahin:develop
Open

Added task solution#3834
nikitachupahin wants to merge 2 commits into
mate-academy:masterfrom
nikitachupahin:develop

Conversation

@nikitachupahin
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: Request changes — one critical checklist requirement is not met.

Issue to fix (Blocker):

  • Location: src/components/Sum/Sum.jsx, the <p> content (likely around the render return lines)
  • Requirement: Use a single string interpolation inside the paragraph to form the exact text: "Sum of X and Y is Z".
  • What’s wrong: The paragraph currently uses multiple JSX expressions ({a}, {b}, {a + b}) instead of one interpolated string. This violates checklist item #2 and the technical constraint to construct the paragraph content in one expression.
  • How to fix: Replace the multiple expressions with a single template literal inside the tag, for example:

    {Sum of ${a} and ${b} is ${a + b}}

    .

What you did well:

  • Correct named export for Sum and proper default values for a and b.
  • App.jsx renders all five required Sum instances with the correct prop combinations and clean single-line JSX.

Once you update the paragraph to a single string interpolation, the submission should fully meet all requirements. Nice work overall—this is a quick fix to bring it to completion!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside the paragraph content to form the text "Sum of X and Y is Z" in one expression.'

Currently, the paragraph uses multiple JSX expressions. It should be:

<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: APPROVE

Your implementation fully meets the requirements:

  • The Sum component is a named export, accepts a and b with defaults of 0, and renders exactly one <p> with the sentence using a single template literal: Sum of ${a} and ${b} is ${a + b}.
  • In App.jsx, all five required Sum usages are present with the correct prop combinations, each written on a single line as specified.

No critical or blocking issues were found. Nice job keeping the code concise, readable, and aligned with the checklist. Keep it up!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants