Skip to content

add task solution#3841

Open
mkravchuk97 wants to merge 2 commits into
mate-academy:masterfrom
mkravchuk97:develop
Open

add task solution#3841
mkravchuk97 wants to merge 2 commits into
mate-academy:masterfrom
mkravchuk97:develop

Conversation

@mkravchuk97
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: Request changes

Your app is very close—functionality, defaults, and component usage all look good. However, there’s one critical checklist violation that needs fixing before approval.

Critical issue to fix

  • src/components/Sum/Sum.jsx: In the paragraph content, you’re using multiple JSX expressions like {a}, {b}, and {a + b}. The checklist requires a single string interpolation expression for the whole sentence. This is important because tests/style checks may enforce this exact format.
    • Why it’s wrong: Violates checklist item #2 requiring one template literal inside the <p>.
    • How to fix: Replace the current content with a single template literal, for example:
      • <p>{Sum of ${a} and ${b} is ${a + b}}</p>
    • Tip: Keep a and b defaulting via destructuring as you’ve done; only change the paragraph content.

What you did well

  • Correct named export/import, default values for a and b, single paragraph output, and the five required Sum instances in App.

Make this small change and you should be all set. Nice work overall—just tighten up that interpolation to meet the checklist!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated
export const Sum = ({ a = 0, b = 0 }) => {
return (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "Inside the paragraph content, use a single string interpolation expression to build the full sentence, e.g., {Sum of ${a} and ${b} is ${a + b}}, rather than concatenating multiple JSX fragments or separate expressions."

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: APPROVE

Great work! Your implementation fully meets the functional and stylistic requirements:

  • Sum is a named export, accepts a and b with defaults to 0, and renders a single <p> with one template string: "Sum of X and Y is Z".
  • App.jsx renders all five Sum instances with the correct prop combinations, each on a single line as required.

No critical blockers or issues found. Everything is clean, consistent, and aligned with the checklist. Nicely done—keep it up!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants