atividade Sum em React by DiegoBalkeKuhn · Pull Request #3845 · mate-academy/react_sum

DiegoBalkeKuhn · 2025-09-02T18:09:49Z

No description provided.

mateacademy-ai-mentor

Review Summary

Decision: REQUEST_CHANGES

Your project shows good structure and use of React, but there are a few critical blockers that prevent the requirements from being met and would likely cause failing tests.

Critical issues to fix

src/components/Sum/Sum.jsx
- Line 1 (component signature): The component currently accepts two positional arguments Sum = (a = 0, b = 0). In React, components receive a single props object. Because of this, <Sum a={2} b={3} /> won’t work as intended. Fix by destructuring from props with defaults, e.g., export const Sum = ({ a = 0, b = 0 }) => { ... }. This also directly satisfies the defaulting requirement (checklist item 3.3).
- Paragraph content: The sentence is split into multiple JSX expressions. The requirement (checklist item #2) is a single template literal expression: {Sum of ${a} and ${b} is ${a + b}}.
src/App.jsx
- Lines rendering Sum instances: The required five cases must be exactly:
 - <Sum a={2} b={3} />
 - <Sum a={-5} b={5} /> (currently reversed)
 - <Sum a={10} /> (omit b)
 - <Sum b={5} /> (omit a)
 - <Sum /> (omit both)
- Reason: This explicitly tests defaulting behavior. Providing zeros for missing props doesn’t validate defaults and violates the checklist/test cases.

Minor improvement

src/index.jsx line ~9: Remove the extraneous <App />; line. It’s harmless but unnecessary.

You’re close—your file structure and named export are solid. Update the Sum signature and paragraph, and adjust the App test cases to match the specs. Once these are fixed, you should meet all requirements. Keep going!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

-    {/* Replace paragraphs with Sum componets */}
-    {/* And remove commented lines :) */}
+    <Sum a={2} b={3} />
+    <Sum a={5} b={-5} />


This violates checklist item #1: 'In App, where a tag has fewer than 3 attributes with short values (as with Sum a and b props), it should be written on a single line.' However, more importantly, the props passed do not match the required test cases. The second instance should be . Additionally, some instances should omit 'a' or 'b' to test defaulting behavior, e.g., , , and .

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

-    {/* And remove commented lines :) */}
+    <Sum a={2} b={3} />
+    <Sum a={5} b={-5} />
+    <Sum a={10} b={0} />


This violates checklist item #1 and the requirements: The third instance should be (b omitted), not . This is necessary to test defaulting of 'b' to 0.

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

+    <Sum a={2} b={3} />
+    <Sum a={5} b={-5} />
+    <Sum a={10} b={0} />
+    <Sum a={0} b={5} />


This violates checklist item #1 and the requirements: The fourth instance should be (a omitted), not . This is necessary to test defaulting of 'a' to 0.

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

+    <Sum a={5} b={-5} />
+    <Sum a={10} b={0} />
+    <Sum a={0} b={5} />
+    <Sum a={0} b={0} />


This violates checklist item #1 and the requirements: The fifth instance should be (both a and b omitted), not . This is necessary to test defaulting of both 'a' and 'b' to 0.

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

@@ -1 +1,5 @@
-// export const Sum = () => ();
+export const Sum = (a = 0, b = 0) => (


This violates the core React functional component pattern. The component should accept a single props object, not two positional arguments. This also violates checklist item #3.3: 'Ensure defaulting of props a and b to 0 is implemented in code (e.g., via default parameter values, defaultProps, or nullish coalescing) so that absence of props results in numeric 0 values in both the displayed text and the computed sum.'

mateacademy-ai-mentor · 2025-09-02T18:13:28Z

+export const Sum = (a = 0, b = 0) => (
+  <p>
+    Sum of {a} and {b} is {a + b}
+  </p>


This violates checklist item #2: 'Construct the paragraph text using a single JSX expression with template literal interpolation, e.g.,
{Sum of ${a} and ${b} is ${a + b}}
'. The current implementation splits the text into multiple JSX expressions instead of using a template literal.

mateacademy-ai-mentor · 2025-09-02T18:13:28Z


 createRoot(document.getElementById('root')).render(<App />);
+
+<App />;


The line <App />; is unnecessary and should be removed. It does not affect functionality but is extraneous and could cause confusion.

mateacademy-ai-mentor

Review Summary

Decision: REQUEST_CHANGES

Your implementation is very close, but there’s one critical blocker related to an explicit checklist requirement.

Critical issue to fix (Checklist item #2):

Location: src/components/Sum/Sum.jsx, in the return statement of Sum.
Issue: The paragraph content is split across multiple JSX expressions: Sum of {a} and {b} is {a + b}. The requirement is to use a single template literal expression inside the paragraph.
Why this matters: The spec explicitly requires one interpolated string. Automated tests may check for this exact pattern and fail otherwise.
How to fix: Replace the paragraph content with a single template literal, for example:
- {Sum of ${a} and ${b} is ${a + b}}

What’s good:

Sum is a named export and correctly destructures a and b with defaults of 0.
App.jsx renders exactly five Sum components with the required props and uses single-line JSX for short tags.

Please make the one-line change above, and you should be fully compliant. Nice work overall—this will be a quick fix!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button² in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag³.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

mateacademy-ai-mentor · 2025-09-02T18:25:31Z

-// export const Sum = () => ();
+export const Sum = ({ a = 0, b = 0 }) => (
+  <p>
+    Sum of {a} and {b} is {a + b}


This violates checklist item #2: "Use string interpolation inside the paragraph content to produce the final sentence in one expression, e.g., {Sum of ${a} and ${b} is ${a + b}}". The current implementation splits the sentence into multiple JSX expressions. Please use a single template literal expression for the paragraph content.

mateacademy-ai-mentor

Review Summary

Great work overall—this is an educational approval to keep you moving forward while you learn. Your components are clean, well-structured, and you correctly used named exports and default values for a and b. One small fix is needed in src/components/Sum/Sum.jsx to meet checklist item #2: on the line rendering the paragraph (likely around the return), you currently have text split across multiple JSX expressions: Sum of {a} and {b} is {a + b}. This violates the requirement to use a single template literal. To fix it, replace the paragraph content with a single string interpolation: {Sum of ${a} and ${b} is ${a + b}}. This ensures the entire sentence is one expression, aligning with the checklist and avoiding potential automated check failures. Everything else looks solid—nice job handling the five Sum cases in App and keeping the JSX concise. Keep it up!

✨ Please rate this review in the Platform's notification center¹. I will be grateful for your feedback! ✨

Rate AI review example ↩

mateacademy-ai-mentor · 2025-09-02T18:51:19Z

@@ -1 +1,3 @@
-// export const Sum = () => ();
+export const Sum = ({ a = 0, b = 0 }) => (
+  <p>Sum of {a} and {b} is {a + b}</p>


This violates checklist item #2: "Inside the paragraph content, use string interpolation to construct the full sentence in one expression, e.g., {Sum of ${a} and ${b} is ${a + b}}, rather than concatenating multiple JSX text nodes and expressions." Please use a single template literal inside the JSX paragraph.

DiegoBalkeKuhn added 2 commits September 2, 2025 15:09

atividade teoricamenet pronta

4f3df33

remoção de linhas comentadas

778c73d

mateacademy-ai-mentor suggested changes Sep 2, 2025

View reviewed changes

DiegoBalkeKuhn added 2 commits September 2, 2025 15:20

modificações referente as recomendações do AI Buddy

072ecce

modified

6b262f9

DiegoBalkeKuhn requested a review from mateacademy-ai-mentor September 2, 2025 18:22

mateacademy-ai-mentor suggested changes Sep 2, 2025

View reviewed changes

DiegoBalkeKuhn added 2 commits September 2, 2025 15:34

commit como o AI BUDDY mandou

82d8d5a

sla

9110aae

DiegoBalkeKuhn requested a review from mateacademy-ai-mentor September 2, 2025 18:35

DiegoBalkeKuhn added 3 commits September 2, 2025 15:35

mudança certo segundo o AI BUDDY

74a4d4c

ta bugando essa bomba já

3234b2d

cu

46638d6

mateacademy-ai-mentor approved these changes Sep 2, 2025

View reviewed changes

só fds esse commit

ce798f4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

atividade Sum em React#3845

atividade Sum em React#3845
DiegoBalkeKuhn wants to merge 10 commits into
mate-academy:masterfrom
DiegoBalkeKuhn:master

DiegoBalkeKuhn commented Sep 2, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Uh oh!

mateacademy-ai-mentor Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		@@ -1 +1,5 @@
		// export const Sum = () => ();
		export const Sum = (a = 0, b = 0) => (


		createRoot(document.getElementById('root')).render(<App />);

		<App />;

Conversation

DiegoBalkeKuhn commented Sep 2, 2025

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

Review Summary

Footnotes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants