Skip to content

solution#3847

Open
PODDN wants to merge 2 commits into
mate-academy:masterfrom
PODDN:develop
Open

solution#3847
PODDN wants to merge 2 commits into
mate-academy:masterfrom
PODDN:develop

Conversation

@PODDN
Copy link
Copy Markdown

@PODDN PODDN commented Sep 2, 2025

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: REQUEST_CHANGES

Your implementation is very close and most requirements are met, but there’s one critical blocker that violates an explicit checklist item and likely enforced checks.

Critical issue to fix

  • Location: src/components/Sum/Sum.jsx (paragraph line where the sum is rendered)
  • Issue: The paragraph content uses multiple JSX expressions ({a}, {b}, {a + b}) instead of a single template literal interpolation.
  • Why it’s wrong: Checklist item #2 requires using a single string interpolation inside the tag content, e.g., using a template literal. This is an explicit requirement and may cause automated checks/tests to fail.
  • How to fix: Replace the paragraph content with a single template literal. For example:
    • <p>{Sum of ${a} and ${b} is ${a + b}}</p>

What you did well

  • Correct named export for Sum and functional component implementation.
  • Proper defaulting of a and b to 0.
  • App.jsx renders exactly five Sum components with the required prop combinations and clean formatting.

Make this small change and you should be fully compliant. Nice work overall—this is a quick fix to get to approval!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated
// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: "Use string interpolation inside tag content for the paragraph text, e.g.,

{Sum of ${a} and ${b} is ${a + b}}

, instead of multiple separate JSX text nodes and expressions." You should use a single template literal interpolation for the paragraph content.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: Approve

Your implementation fully meets the functional and stylistic requirements:

  • Sum is a named export that accepts a and b, both defaulting to 0 when not provided.
  • The component renders exactly one <p> with the precise text format using a single template literal.
  • App renders all required Sum instances (both props, only a, only b, neither) and keeps JSX with fewer than three short attributes on one line.

No critical blockers or issues were found. Nice job keeping the code clean, concise, and idiomatic. Great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants