Skip to content

add tasc#3852

Open
Mishadoloh wants to merge 2 commits into
mate-academy:masterfrom
Mishadoloh:master
Open

add tasc#3852
Mishadoloh wants to merge 2 commits into
mate-academy:masterfrom
Mishadoloh:master

Conversation

@Mishadoloh
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: REQUEST_CHANGES — One explicit checklist requirement is violated.

Why: The Sum component’s paragraph content must be built using a single template literal inside the <p> tag. Currently, it’s split across multiple JSX fragments, which violates checklist item #2 and an explicit implementation detail.

Critical issues to fix (blockers):

  • Location: src/components/Sum/Sum.jsx
    • Likely around the <p> tag where the text is rendered (e.g., lines where you have Sum of {a} and {b} is {sum}).
    • Requirement: Use a single string interpolation expression inside <p>: {Sum of ${a} and ${b} is ${a + b}}.
    • Why it’s wrong: The checklist explicitly mandates a single template literal; splitting into multiple JSX nodes doesn’t meet this requirement, even if the output looks the same.
    • How to fix (hint): Replace the fragmented JSX with a single template literal. Example:
      • <p>{Sum of ${a} and ${b} is ${a + b}}</p>

What you did well:

  • Correct default values for a and b (default to 0).
  • Named export for Sum is correct.
  • App.jsx renders all five required combinations on single lines where appropriate.

Please make the single-line template literal change in Sum.jsx. Once that’s in place, this will meet all requirements. Nice work overall—this is a quick, one-line fix!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated

return (
<p>
Sum of {a} and {b} is {sum}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: 'Use string interpolation inside the paragraph content to build the text in a single expression: {Sum of ${a} and ${b} is ${a + b}}'.

Currently, the content is split into multiple JSX fragments. It should be a single template literal expression inside the

tag.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: APPROVE

Great work! All core requirements are fully met:

  • Sum is a named export functional component that accepts a and b, defaults both to 0, and renders exactly one <p> with the required template literal: Sum of {a} and {b} is {a + b}.
  • App.jsx renders the five required Sum usages with the specified prop combinations, each on a single line as per the style guideline.
  • No runtime issues or broken functionality were found; output matches the exact expected format.

No critical blockers or checklist violations were identified. Nice job keeping the implementation clean and focused. Keep it up!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants