Props first#3875
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the core functionality of the Sum component! The logic for calculating the sum and handling default props is working perfectly.
However, I need to request one change to align with the project's code style guidelines. In src/components/Sum/Sum.jsx, the text content inside the <p> tag must be constructed using a single string interpolation (template literal), as specified in checklist item #2.
Currently, you have:
<p>
Sum of {a} and {b} is {a + b}
</p>Please update it to use backticks like this:
<p>
{`Sum of ${a} and ${b} is ${a + b}`}
</p>This is an important code style requirement for this project. Once you've made this quick fix, I'll be happy to approve your work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| export const Sum = ({ a = 0, b = 0 }) => { | ||
| return ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This implementation works, but it violates checklist item #2, which requires using string interpolation (template literals) to construct the text content.
The checklist provides this example for the correct approach:
<p>
{`Sum of ${a} and ${b} is ${a + b}`}
</p>Using a template literal makes the string a single, cohesive expression, which is generally easier to read and maintain.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this pull request! You've successfully addressed the feedback from the previous review and implemented the Sum component perfectly. The code is clean, functional, and fully aligns with all the task requirements, including the specific code style guidelines. This submission is now in great shape and meets all criteria.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK