result#3878
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the core functionality! The Sum component works correctly, and App.jsx is perfectly set up.
However, one change is needed in src/components/Sum/Sum.jsx to meet the project's coding standards. Checklist item #2 requires using string interpolation for text content inside JSX tags.
Your current code is:
<p>Sum of {a} and {b} is {a + b}</p>Please update it to use a template literal like this:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Once you make this small adjustment, your work will be ready to be approved. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This implementation is functionally correct, but it doesn't follow the code style guide from the checklist.
Checklist item #2 states: "Use string interpolation inside tag content". This means the entire string should be wrapped in backticks () and placed inside a single pair of curly braces {}`.
Take a look at the 'GOOD EXAMPLE' in the checklist for guidance on how to reformat this line.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this submission! You've successfully implemented all requirements for the Sum component and its rendering in App.jsx. It's great to see that you've addressed the feedback from the previous review by using string interpolation. The code is clean, correct, and fully meets all project standards. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK