Skip to content

Solution#3920

Closed
pavlov-matt wants to merge 3 commits into
mate-academy:masterfrom
pavlov-matt:develop
Closed

Solution#3920
pavlov-matt wants to merge 3 commits into
mate-academy:masterfrom
pavlov-matt:develop

Conversation

@pavlov-matt
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Decision: REQUEST_CHANGES

Your Sum component is implemented correctly (named export, defaults, and string interpolation are spot on). However, src/App.jsx does not render any Sum components, which violates the task requirements and will cause tests to fail.

Critical issues to fix:

  • In src/App.jsx, replace the placeholder <p> elements (e.g., lines where you currently show “Sum a={2} and b={3}”) with the five required Sum usages: import { Sum } from './components/Sum/Sum'; then render: <Sum a={2} b={3} />, <Sum a={-5} b={5} />, <Sum a={10} />, <Sum b={5} />, and <Sum />. This addresses the requirement that App must render the specified five Sum components.
  • [CHECKLIST ITEM #1] Ensure each Sum usage is a single-line JSX tag since each has fewer than three short attributes (e.g., <Sum a={2} b={3} />).

Minor note:

  • [CHECKLIST ITEM #2] Avoid splitting text/props across multiple JSX expressions in App.jsx; rely on the Sum component’s interpolation.

Make these changes and you should be all set—great work on the Sum component itself!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/App.jsx
Comment on lines +6 to +16
<p>
Sum a={2}
b={3}
</p>
<p>
Sum a={-5}
b={5}
</p>
<p>Sum a={10}</p>
<p>Sum b={5}</p>
<p>Sum</p>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates the task description requirement that the App must render the specified five Sum components. The description explicitly states: "The App should contain the next Sum components:

  • a = 2 and b = 3;
  • a = -5 and b = 5;
  • just a = 10;
  • just b = 5;
  • no params at all." Replace the current placeholder <p> elements with the five Sum usages and import Sum at the top of this file. See the description for the exact required items.

Comment thread src/App.jsx
Comment on lines +6 to +13
<p>
Sum a={2}
b={3}
</p>
<p>
Sum a={-5}
b={5}
</p>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2 (string interpolation inside tag content). The checklist states: "[CODE STYLE] - Use string interpolation inside tag content" and shows the bad example that splits text and variables across multiple JSX expressions. The current <p> blocks split the text and props across lines (e.g. Sum a={2} and b={3} on separate lines) which matches the bad example. Instead, rely on the Sum component that already uses interpolation ({Sum of ${a} and ${b} is ${a + b}}) or, if you render directly, use the interpolation form.

Comment thread src/App.jsx
Comment on lines +14 to +16
<p>Sum a={10}</p>
<p>Sum b={5}</p>
<p>Sum</p>
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #1 requires single-line JSX for tags with fewer than three short attributes. The checklist says: "If you have < 3 attribues on a tag and the values are short write the tag in one line ... GOOD EXAMPLE: <Sum a={2} b={3} />". When you replace these placeholders with Sum components, render them as single-line tags (e.g. <Sum a={2} b={3} />, <Sum a={10} />) to comply with the style rule.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

No changes were made in the pull request since the last review. Please make sure that you have added files to the pull request and committed the changes.
[CODE: NCM]

If the issue is within your control, please address it.
The next review attempt will automatically launch in about 1 hour.
If you believe this is an error or need assistance, please contact the support team.

@pavlov-matt pavlov-matt closed this by deleting the head repository Oct 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants