finished project#3923
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Decision: Request Changes — There are critical requirement mismatches that block acceptance.
- In
src/App.jsx, the required examples must omit props exactly as specified. Please update:- Line with
<Sum a={10} b={0} />→ use<Sum a={10} />(demonstrates “just a = 10”). - Line with
<Sum a={0} b={5} />→ use<Sum b={5} />(demonstrates “just b = 5”). - Line with
<Sum a={0} b={0} />→ use<Sum />(demonstrates “no params at all”).
These are core task requirements; passing explicit zeros does not satisfy the “omitted prop” cases.
- Line with
- In
src/components/Sum/Sum.jsx, [CHECKLIST ITEM #2] requires string interpolation inside the tag content. Change the paragraph from separate JSX expressions to a single interpolated string, e.g.<p>{Sum of ${a} and ${b} is ${a + b}}</p>.
What’s good: the component uses named export and sensible defaults (a=0, b=0), and other required cases are present. Make these adjustments and you should be all set. ✅
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| {/* And remove commented lines :) */} | ||
| <Sum a={2} b={3} /> | ||
| <Sum a={-5} b={5} /> | ||
| <Sum a={10} b={0} /> |
There was a problem hiding this comment.
This line violates the task requirement that the App should include the case: "just a = 10". Currently you're rendering <Sum a={10} b={0} />. Please omit b to demonstrate the "just a = 10" case exactly as required: <Sum a={10} />. See the description's list of required Sum usages.
| <Sum a={2} b={3} /> | ||
| <Sum a={-5} b={5} /> | ||
| <Sum a={10} b={0} /> | ||
| <Sum a={0} b={5} /> |
There was a problem hiding this comment.
This line violates the task requirement that the App should include the case: "just b = 5". Currently you're rendering <Sum a={0} b={5} />. Please omit a to demonstrate the "just b = 5" case exactly as required: <Sum b={5} />. See the description's list of required Sum usages.
| <Sum a={-5} b={5} /> | ||
| <Sum a={10} b={0} /> | ||
| <Sum a={0} b={5} /> | ||
| <Sum a={0} b={0} /> |
There was a problem hiding this comment.
This line violates the task requirement that the App should include the case: "no params at all.". Currently you're rendering <Sum a={0} b={0} />. Please omit both props to demonstrate the no-params case exactly as required: <Sum />. See the description's list of required Sum usages.
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: "2. [CODE STYLE] - Use string interpolation inside tag content"
The current paragraph builds the content with separate JSX expressions: Sum of {a} and {b} is {a + b}. The checklist expects a single interpolated string inside the tag, for example:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Please update the
content to use this string interpolation pattern so it matches the requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Decision: REQUEST_CHANGES
Your implementation is very close, but there’s one critical checklist violation that must be fixed before approval. In src/components/Sum/Sum.jsx, the paragraph content uses multiple JSX expressions: Sum of {a} and {b} is {a + b} (likely around the line rendering the <p>). This violates the enforced style requirement [CHECKLIST ITEM #2]: use a single template string for tag content. Please change the paragraph to use string interpolation, e.g., <p>{Sum of ${a} and ${b} is ${a + b}}</p>. This keeps the entire sentence within one interpolated string and satisfies the checklist. Everything else (named export, default props, required usages in App) looks good—once this style fix is made, it should be ready to approve. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
This violates checklist item #2: "2. [CODE STYLE] - Use string interpolation inside tag content"
The paragraph currently uses separate JSX expressions and text nodes: Sum of {a} and {b} is {a + b}. Update the paragraph to use a single interpolated string inside the tag, for example:
<p>{`Sum of ${a} and ${b} is ${a + b}`}</p>Please make this change so the file satisfies the checklist requirement.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work! Your Sum component uses a named export, defaults a and b to 0, and renders exactly one interpolated paragraph like “Sum of X and Y is Z” [CHECKLIST ITEM #2]. In App.jsx, you render the five required instances with correct props and keep short JSX tags on a single line [CHECKLIST ITEM #1].
Minor improvement: please ensure your PR description includes the required demo link (https://<your_account>.github.io/react_sum/) and run npm test to confirm all tests pass. If CI flags anything, it’s often due to formatting or export type, which you’ve already handled well here.
Educational override note: Approving to help you progress while learning; remember to add the demo link to fully meet the submission requirements. Nicely done—clean, concise, and aligned with the task!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.