Skip to content

Solution#4257

Open
nyarachun wants to merge 2 commits into
mate-academy:masterfrom
nyarachun:develop
Open

Solution#4257
nyarachun wants to merge 2 commits into
mate-academy:masterfrom
nyarachun:develop

Conversation

@nyarachun
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The request meets the required criteria for approval.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +2 to +3
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. The current implementation uses separate JSX expressions {a}, {b}, {a + b} instead of template literal syntax. Change to: {Sum of ${a} and ${b} is ${a + b}}

Comment thread src/App.jsx
@@ -1,14 +1,13 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #2 violation: This uses JSX expression syntax ({a}, {b}, {a + b}) instead of template literal string interpolation. The good example shows: {Sum of ${a} and ${b} is ${a + b}} using backticks and ${} syntax.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants