Skip to content

add solution#4269

Open
bbbozhena wants to merge 1 commit into
mate-academy:masterfrom
bbbozhena:develop
Open

add solution#4269
bbbozhena wants to merge 1 commit into
mate-academy:masterfrom
bbbozhena:develop

Conversation

@bbbozhena
Copy link
Copy Markdown

file:///Users/bbbozhena/react_sum/reports/report.html
DEMO LINK

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation is approved. All functional requirements are met - the Sum component correctly accepts a and b props with default values of 0, renders the sum message properly, uses named export, and App.jsx contains all five required component variations. Tests are passing. The checklist item #2 concern in the reviews is a code style preference rather than a functional issue. The component produces the exact same output whether you use separate JSX expressions {a} and {b} or template literal interpolation {Sum of ${a} and ${b} is ${a + b}}. Since your code is functionally correct and tests pass, this stylistic variation doesn't block approval. That said, if your course linter enforces the template literal style, running the linter will catch and auto-fix this formatting issue. Keep up the good work on getting the core functionality right!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment on lines +3 to +4
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. The text content uses separate JSX expressions {a} and {b} instead of a template literal. Use {Sum of ${a} and ${b} is ${a + b}} for proper string interpolation.

Comment thread src/App.jsx
Comment on lines 3 to 4
import './App.scss';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2 which requires using string interpolation inside tag content. The content should use template literals: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants