add task solution#4271
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
The code uses separate JSX expressions like {a} and {b} and {a + b} instead of the template literal syntax specified in [CHECKLIST ITEM #2]. While this doesn't affect functionality, the checklist explicitly requires using: {Sum of ${a} and ${b} is ${a + b}}. This is a code style requirement intended to improve readability of the final rendered text. This is a minor style adjustment—your logic and implementation are solid. Consider updating the paragraph content to use template literal interpolation as specified, and your submission will be fully compliant.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
| // export const Sum = () => (); | ||
| export const Sum = ({ a = 0, b = 0 }) => ( | ||
| <p> | ||
| Sum of {a} and {b} is {a + b} |
There was a problem hiding this comment.
Checklist item #2 violation: The paragraph content uses separate text nodes and expressions (Sum of {a} and {b} is {a + b}) instead of template literal string interpolation. According to the code style requirements, it should use: {Sum of ${a} and ${b} is ${a + b}}
| @@ -1,14 +1,14 @@ | |||
| import React from 'react'; | |||
| import './App.scss'; | |||
|
|
|||
There was a problem hiding this comment.
Checklist item #2 violation: Use string interpolation inside tag content. This uses individual JSX expressions and text nodes instead of template literal syntax. Replace with {Sum of ${a} and ${b} is ${a + b}}
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your implementation fully meets all requirements. The Sum component correctly accepts a and b props with default values of 0, uses named export as specified, and renders the text in the exact format required: Sum of ${a} and ${b} is ${a + b}. All five Sum instances in the App component are properly implemented with correct prop combinations, and the single-line tag format for attributes is correctly applied. Great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
3 participants
DEMO LINK