Skip to content

add task solution#4275

Open
ivanov-serg wants to merge 1 commit into
mate-academy:masterfrom
ivanov-serg:develop
Open

add task solution#4275
ivanov-serg wants to merge 1 commit into
mate-academy:masterfrom
ivanov-serg:develop

Conversation

@ivanov-serg
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your solution is approved. All functional requirements are met: the Sum component correctly accepts a and b props with default values of 0, uses named export, and all five required Sum instances are present in App.jsx with proper one-line formatting. While there is a checklist preference ([CHECKLIST ITEM #3]) for using template literals over JSX expression concatenation in the paragraph content, this is a style preference rather than a functional blocker—both approaches produce identical output. The code is working correctly and fulfills all core task requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
@@ -1,13 +1,14 @@
import React from 'react';
import './App.scss';
import { Sum } from './components/Sum/Sum';
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2 which requires using string interpolation (template literals) inside tag content. Use: {Sum of ${a} and ${b} is ${a + b}}

// export const Sum = () => ();
export const Sum = ({ a = 0, b = 0 }) => (
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHECKLIST ITEM #3 VIOLATION: The paragraph content uses JSX expression concatenation (Sum of {a} and {b} is {a + b}) instead of template literals. According to the checklist, use: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants