Skip to content

Sayao - Soma React prop#4276

Open
sistsayao-hue wants to merge 1 commit into
mate-academy:masterfrom
sistsayao-hue:develop
Open

Sayao - Soma React prop#4276
sistsayao-hue wants to merge 1 commit into
mate-academy:masterfrom
sistsayao-hue:develop

Conversation

@sistsayao-hue
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation correctly fulfills all functional requirements. The Sum component properly accepts a and b props with default values of 0, uses named export, and the App renders all five required Sum instances with the correct prop combinations. Regarding the checklist item #2 concern about string interpolation: while the checklist suggests using template literals, your current implementation using separate JSX expressions produces the exact same output and doesn't affect functionality. This is a style preference rather than a functional issue. The code is working correctly and meets all core requirements.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Comment thread src/App.jsx
Comment on lines +5 to +6


Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2: Use string interpolation inside tag content. Replace with {Sum of ${a} and ${b} is ${a + b}} instead of separate expressions.

Comment on lines +5 to +6
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This violates checklist item #2 which requires using string interpolation inside tag content. Use template literals instead: {Sum of ${a} and ${b} is ${a + b}}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants