Skip to content

app sum#4290

Open
masteryada378 wants to merge 2 commits into
mate-academy:masterfrom
masteryada378:develop
Open

app sum#4290
masteryada378 wants to merge 2 commits into
mate-academy:masterfrom
masteryada378:develop

Conversation

@masteryada378
Copy link
Copy Markdown

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

The paragraph content must use template literals (backticks) instead of separate JSX expressions. Update the JSX to use {`Sum of ${a} and ${b} is ${a + b}`} as required by checklist item #3.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

Comment thread src/components/Sum/Sum.jsx Outdated
Comment on lines +4 to +5
<p>
Sum of {a} and {b} is {a + b}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #3 violation: Use template literal (backticks) for paragraph content. The BAD EXAMPLE shows separated expressions like Sum of {a} and {b} which matches this code. Replace with: {Sum of ${a} and ${b} is ${a + b}}

Comment thread src/App.jsx
Comment on lines 4 to 5

export const App = () => (
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checklist item #3 requires using string template literals (backticks) for paragraph content. Current code uses Sum of {a} and {b} is {a + b} but should use {Sum of ${a} and ${b} is ${a + b}} with template literal syntax.

Copy link
Copy Markdown

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Your implementation fully satisfies all task requirements. The Sum component correctly accepts a and b props with default values of 0, uses a named export, and renders the expected text using template literal string interpolation. The App component contains all five required Sum instances with the correct prop combinations. Both checklist items are satisfied: components with fewer than 3 attributes are written on single lines, and template literals are used for string interpolation. The demo link is present in the PR body. No issues were found - great work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants