cards for all sizes, header only fullHD & IMac, without footer #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkryvytskyi
approved these changes
Jan 15, 2020
Comment on lines
27
to
33
| <RestaurantCard | ||
| categories={categories} | ||
| heroImageUrl={heroImageUrl} | ||
| title={title} | ||
| uuid={uuid} | ||
| etaRange={etaRange.text} | ||
| /> |
vpolets
approved these changes
Mar 4, 2020
| @@ -1 +1,286 @@ | |||
| .restaurant_card { | |||
| width: 100%; | |||
| display: inline-block; | ||
| font-size: 14px; | ||
| line-height: 24px; | ||
| margin-top: 7px; |
| margin: 0; | ||
| } | ||
|
|
||
| .non-active { |
Comment on lines
+47
to
+64
| {width > 400 ? ( | ||
| <> | ||
| <h3 className="card__title">{dish.title}</h3> | ||
| <p className="card__description"> | ||
| { | ||
| // eslint-disable-next-line no-nested-ternary | ||
| dish.description !== null | ||
| ? (dish.title.length < 30 || width > 900 | ||
| ? dish.description.slice(0, 50) | ||
| : dish.description.slice(0, 20) | ||
| ) : '' | ||
| } | ||
| </p> | ||
| </> | ||
| ) : ( | ||
| <> | ||
|
|
||
| {dish.title.length <= 30 |
There was a problem hiding this comment.
це прямо супер дивно. Тут краще просто вішатиякісь класи. Я особливо не вникаю що робить цей код, але загалом виглядає дивною Певен звичайним класом вирішується
| src={dish.imageUrl !== null && dish.imageUrl !== '' | ||
| ? `${dish.imageUrl}` | ||
| // eslint-disable-next-line max-len | ||
| : `https://thecustompackagingboxes.com/wp-content/uploads/2014/09/Chinese_food_boxes_3-compressed.jpg`} |
Comment on lines
+37
to
+58
| <ul className="footer__about"> | ||
| <li className="footer__item"> | ||
| <a className="link" href="/#"> | ||
| About UberEats | ||
| </a> | ||
| </li> | ||
| <li className="footer__item"> | ||
| <a className="link" href="/#"> | ||
| Read our blog | ||
| </a> | ||
| </li> | ||
| <li className="footer__item"> | ||
| <a className="link" href="/#"> | ||
| Sign up to deliver | ||
| </a> | ||
| </li> | ||
| <li className="footer__item"> | ||
| <a className="link" href="/#"> | ||
| Add your restaurant | ||
| </a> | ||
| </li> | ||
| </ul> |
|
|
||
| return ( | ||
| <> | ||
| { width < 1279 ? ( |
There was a problem hiding this comment.
і знову тут кондішинал. Рендери все і ховай класами. Це буде більш безболісно для браузера. По можливості уникай ресайзу і вирішуй це через media query
| default: return state; | ||
| } | ||
| }; | ||
|
|
Comment on lines
+1
to
+8
| $ceilWidthFullHD: 348px; | ||
| $ceilWidthIPad: 340px; | ||
| $ceilWidthIPhone2_1: 280px; | ||
| $columnGap: 20px; | ||
|
|
||
| $max-widthFullHd: 1979px; | ||
| $max-widthIMac: 1279px; | ||
| $max-widthIPad: 767px; |
There was a problem hiding this comment.
більше змінних немає? transition durations, colors
| padding: 0; | ||
| } | ||
|
|
||
| link { |
There was a problem hiding this comment.
link? що це за тег, він ж тільки в head юзається
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://anastasiiakonovalenko.github.io/react_uber-eats/