Skip to content

Conversation

@mbkma
Copy link
Member

@mbkma mbkma commented Jun 6, 2021

shell: Add EvFindSidebar widget to show search results
see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface

eggfindbar: don't close the findbar when it loses the focus
see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef

shell: Add the findbar to the main box instead of the view box

libview: Add ev_view_find_set_result

Fixes #238

@mbkma mbkma requested a review from a team June 6, 2021 08:27
@raveit65
Copy link
Member

I tried to back port the same functionality 2 years ago or so. So i like this.
But i recall that there was a lot of more commits which are related to the new search sidebar, but i am not sure.

@raveit65
Copy link
Member

Beside from a few code-style issues it works fine, thanks.

@mbkma
Copy link
Member Author

mbkma commented Jul 10, 2021

This does not work with epub documents yet...

@raveit65
Copy link
Member

@mbkma
Any chance to fix code-style issues?

@raveit65
Copy link
Member

Opps, cross posting :)

shell: Add EvFindSidebar widget to show search results
see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface

eggfindbar: don't close the findbar when it loses the focus
see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef

shell: Add the findbar to the main box instead of the view box

libview: Add ev_view_find_set_result
@mbkma mbkma requested a review from a team December 30, 2025 15:11
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, though use is a bit counterintuative. The search sidebar is brought up by and only by clicking on the search icon in toolbar, which brings up the previous search gui plus a sidebar listing all findings of the word searched for (tested using a word). This comes up automatically, overriding other sidebars such as thumbnails. I had expected to be able to select it from the sidebar mode combo box.

None the less, this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature request] backport search functionality from evince

4 participants