-
-
Notifications
You must be signed in to change notification settings - Fork 70
Improve search system #532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I tried to back port the same functionality 2 years ago or so. So i like this. |
|
Beside from a few code-style issues it works fine, thanks. |
|
This does not work with epub documents yet... |
|
@mbkma |
|
Opps, cross posting :) |
shell: Add EvFindSidebar widget to show search results see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface eggfindbar: don't close the findbar when it loses the focus see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef shell: Add the findbar to the main box instead of the view box libview: Add ev_view_find_set_result
lukefromdc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, though use is a bit counterintuative. The search sidebar is brought up by and only by clicking on the search icon in toolbar, which brings up the previous search gui plus a sidebar listing all findings of the word searched for (tested using a word). This comes up automatically, overriding other sidebars such as thumbnails. I had expected to be able to select it from the sidebar mode combo box.
None the less, this works
shell: Add EvFindSidebar widget to show search results
see https://gitlab.gnome.org/GNOME/evince/-/commit/940ce8048e4fc6503dca03c1ce090ff4a11dface
eggfindbar: don't close the findbar when it loses the focus
see https://gitlab.gnome.org/GNOME/evince/-/commit/a2d781fb124bd19861035fd41dacc976e00d19ef
shell: Add the findbar to the main box instead of the view box
libview: Add ev_view_find_set_result
Fixes #238