Skip to content

drop Python 2 support#50

Merged
lukefromdc merged 1 commit intomasterfrom
drop-python2
Dec 25, 2019
Merged

drop Python 2 support#50
lukefromdc merged 1 commit intomasterfrom
drop-python2

Conversation

@monsta
Copy link
Contributor

@monsta monsta commented Dec 17, 2019

I've tested this with extensions like caja-admin, caja-mediainfo, caja-rename. In Debian, the patched versions of these extensions can be downloaded from Experimental repo (thanks to @sunweaver for porting).

it's going EOL in 2020
@monsta monsta requested review from a team December 17, 2019 13:06
Copy link
Member

@lukefromdc lukefromdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A build of this with python 3.7 and my (usual) python 3.7 build of caja-admin worked fine. I have stripped as much of python 2 out of my box as I could get away with for space reasons.

As usual for Debian I had to apply this patch by hand:

-PYTHON_LIB_LOC="`${PKG_CONFIG} ${PYTHON_PKG} --variable=libdir`"
+PYTHON_LIB_LOC="`pkg-config gobject-introspection-1.0 --variable=libdir`"

@lukefromdc lukefromdc requested a review from a team December 17, 2019 20:20
Copy link
Member

@yetist yetist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lukefromdc lukefromdc merged commit 8a6ccef into master Dec 25, 2019
@lukefromdc lukefromdc deleted the drop-python2 branch December 25, 2019 21:57
@yetist yetist mentioned this pull request Dec 26, 2019
@Erriez Erriez mentioned this pull request Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants