Added option numberOfPagesAround#501
Merged
Domino987 merged 5 commits intomaterial-table-core:masterfrom Mar 6, 2022
Merged
Conversation
Domino987
requested changes
Mar 3, 2022
Contributor
Domino987
left a comment
Domino987
left a comment
There was a problem hiding this comment.
There are a few chages but overall this looks great. Thank you. Could you also add it to the typescript types file?
Domino987
approved these changes
Mar 5, 2022
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Show more pages around current page in stepped pagination
Description
I added new option 'numberOfPagesAround'. With that you tell how many pages you want to see around current page in Stepped Pagination.
Impacted Areas in Application
tests/demo/demo.js, tests/demo/demo-components/index.js - added demo
src/material-table.js - passing props
src/prop-types.js - type check with custom Error msg
src/defaults/props.options.js - default value (1)
src/components/MTableSteppedPaginationInner/index.js - actual logic of showing more pages around current page
Additional Notes
My first PR to a public repo, so be merciful, but of course don't be afraid to criticize.