(feature) Allow custom hide columns action#833
Merged
Domino987 merged 5 commits intomaterial-table-core:masterfrom Apr 19, 2024
Merged
(feature) Allow custom hide columns action#833Domino987 merged 5 commits intomaterial-table-core:masterfrom
Domino987 merged 5 commits intomaterial-table-core:masterfrom
Conversation
EmilianoMorghen
changed the title
Domino987
requested changes
Mar 27, 2024
Contributor
Domino987
left a comment
Domino987
left a comment
There was a problem hiding this comment.
This looks good and should be a good addition, one minor change it is good to go. Thank you
Domino987
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Team,
First and foremost, I want to express my heartfelt gratitude for the incredible work each of you has contributed. Over the past year, I've had the pleasure of utilizing this package, and I must say, I've thoroughly enjoyed it.
Description
Upon delving into how custom actions are rendered and handled, I've observed that they lack access to crucial data such as
columnsand event callbacks likeonColumnsChangedoronSearchChanged. Providing access to this data would empower users to customize the behavior of default actions.Impacted Areas in Application
List general components of the application that this PR will affect:
MTableToolbarMTableActionsMTableActionAdditional Notes
There are multiple approaches to implementing the overwrite of default actions' behavior, and I am open to hearing your insights on the matter.
I am eager to tackle this task with your expert guidance and oversight, ensuring that we maintain the highest quality standards that you consistently uphold.