Fix crash on parseISO import from date-fns v3.x. (Fixes #838)#840
Merged
Domino987 merged 1 commit intomaterial-table-core:masterfrom Apr 28, 2024
Merged
Fix crash on parseISO import from date-fns v3.x. (Fixes #838)#840Domino987 merged 1 commit intomaterial-table-core:masterfrom
Domino987 merged 1 commit intomaterial-table-core:masterfrom
Conversation
Domino987
approved these changes
Apr 28, 2024
Contributor
|
Thanks, I'll merge it Thursday. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Description
date-fns v3.x has a slightly different import syntax which causes material-table to crash when it tries to import parseISO.
This problem makes the
dateanddatetimefields unusable.This PR fixes it by using the correct import syntax according to this comment.
Related PRs
Impacted Areas in Application
dateordatetimetypeAdditional Notes
Demos: