Update passing localization object for children rows#845
Merged
Domino987 merged 1 commit intomaterial-table-core:masterfrom May 21, 2024
Merged
Update passing localization object for children rows#845Domino987 merged 1 commit intomaterial-table-core:masterfrom
Domino987 merged 1 commit intomaterial-table-core:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
#830 - Child row of a child row does not show "Are you sure you want to delete this row?"
Description
In local testing, the localization wouldn't always pass the same object to children rows for editing. Thus the deleteText would not exist.
Added localization.editRow and this gave the row the correct information to display the appropriate deleteText
Impacted Areas in Application
When a table is utilizing parent/child and inline row editing, children of children would not display the deleteText.
*