Skip to content

Jointstore#23

Merged
shyamd merged 18 commits intomaterialsproject:masterfrom
montoyjh:jointstore
Sep 30, 2018
Merged

Jointstore#23
shyamd merged 18 commits intomaterialsproject:masterfrom
montoyjh:jointstore

Conversation

@montoyjh
Copy link
Contributor

A store that can use the lookup aggregation functionality to query sub collections along with a master collection such that documents in sub collections with matching keys as the master will be treated as subdocuments of master docs.

e. g. you have two collections, master and sub1:

js = JointStore(...)
docs = query([key1, sub1.key2], {"sub1.key2": {"$gt": 3}})

etc.

@dwinston
Copy link
Member

(Probably) beyond the scope of maggma, but related to the problem that a "jointstore" would solve, I have been looking into GraphQL (in particular, the Apollo implementation) with great interest for providing a unified, single-endpoint API as a layer above a multitude of Stores. I think a basic jointstore could also be useful, though, providing a familiar Mongo/Store API.

@montoyjh
Copy link
Contributor Author

Okay there's one outstanding codacy issue that I think is okay, but this should be ready to go. I suspect there might still be some bugs, but all of the functionality is tested.

@montoyjh montoyjh changed the title [WIP]: Jointstore Jointstore Sep 29, 2018
@shyamd shyamd merged commit 1676d11 into materialsproject:master Sep 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants