Conversation
|
Code Climate has analyzed commit 8734d84 and detected 8 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 36.2% (50% is the threshold). This pull request will bring the total coverage in the repository to 40.5% (7.0% change). View more on Code Climate. |
* Algorithm Created - Designed and partially tested an algorithm which more closely hits target frame rates. - Optimized imports. - Weakened GraphicsPanel object in GraphicsThread to GraphicsPanelInterface. - Added repaint() to GraphicsPanelInterface. This is typically implemented by Component. [API CHANGE!!!] - Created GraphicsThreadTest. - Started writing test for run(). * Optimizations - Slightly modified algorithm which did result in an 'overperformance' error of 1.5%. After removing some 'unused code' now at roughly 9%. - Created parameterized test for running at requested frame rate. - Updated Gradle wrapper to Gradle 7.5. * Mostly Done - Shortened test durations. - Made tests automatically pause with an easy way to re-enable them. - 'Normalized' the 'remainingMillis' count when determining how long to wait by subtracting the start time. - Added a simple report result message so tests can still be useful. * FrameRate - Added setters and getters for the current target frame rate. * - Extracted commonalities between SugaThread implementing classes to AbstractThread. * - Wrote tests for GameLogicThread. * - Attempted to fix workflow. * - Finished fixing merge differences.
Owner
Author
|
Building and testing worked on local system. Pushing this request through so progress can begin on v4.0.0 as that will significantly change distribution anyways. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #30.