Update tcgascope.js#1
Open
tdiprima wants to merge 1 commit intomathbiol:gh-pagesfrom
tdiprima:patch-1
Open
Conversation
1) Code was failing upon selecting LGG, and then executing the part that writes Diagnostic Images to the screen. This part of the code needed to be commented out, just as you do when doing openHealth.getText for GBM: // x = x.replace(/}/g, '},'); // x = '[' + x.slice(0, -2) + ']'; 2) Also, data itself is not well formed (lgg_patientids.json). I will create a pull request for that as well, shortly. Both changes need to be implemented in order for this to work properly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This part of the code needed to be commented out, just as you do when doing openHealth.getText for GBM:
// x = x.replace(/}/g, '},');
// x = '[' + x.slice(0, -2) + ']';