「適当ポエム」フォントの追加 #116
「適当ポエム」フォントの追加 #116
Conversation
✅ Deploy Preview for sync-timer ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
WalkthroughA new handwritten-style font, "Tekitou-Poem-SemiBold," was integrated into the project. This included updating CSS for font loading and styling, adding localization labels, extending the model to support the new font, and updating the UI to allow users to select it. Debug logging was also added to analytics event handling. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI (View.elm)
participant Model (Model.elm)
participant I18n (I18n.elm)
participant CSS
User->>UI (View.elm): Opens font dropdown
UI (View.elm)->>I18n (I18n.elm): Fetches localized font labels
UI (View.elm)->>Model (Model.elm): Lists available FgFont variants (including TekitouPoem)
User->>UI (View.elm): Selects "Tekitou Poem"
UI (View.elm)->>Model (Model.elm): Updates selected font to TekitouPoem
UI (View.elm)->>CSS: Applies `.timer.tekitou-poem` class
CSS-->>User: Renders timer with "Tekitou-Poem-SemiBold" font
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
js/common.js (1)
68-69: Guard debug logging in production
Theseconsole.debugstatements may clutter logs or expose user settings; consider wrapping them in a debug-mode flag (e.g., checking an environment variable) or removing them prior to release.src/Model.elm (1)
1-1: Format with elm-format
The pipeline reports this file isn’t formatted withelm-format --elm-version=0.19. Please runelm-formatto satisfy the CI check.🧰 Tools
🪛 GitHub Actions: Check
[error] 1-1: File is not formatted with elm-format-0.8.7 --elm-version=0.19. Run 'elm-format' to fix formatting issues.
css/main.scss (2)
43-51: Verify@font-faceasset path and properties
EnsureTekitou-Poem-SemiBold.woff2is correctly included in your build output, and consider specifyingfont-weightor adding fallback fonts for robustness.
113-115: Add fallback fonts for handwriting style
To guard against load failures, extend the rule, e.g.:.timer.tekitou-poem { font-family: "Tekitou-Poem-SemiBold", cursive, sans-serif; }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
css/Tekitou-Poem-SemiBold.woff2is excluded by!**/*.woff2
📒 Files selected for processing (5)
css/main.scss(2 hunks)js/common.js(1 hunks)src/I18n.elm(3 hunks)src/Model.elm(3 hunks)src/View.elm(1 hunks)
🧰 Additional context used
🪛 GitHub Actions: Check
src/Model.elm
[error] 1-1: File is not formatted with elm-format-0.8.7 --elm-version=0.19. Run 'elm-format' to fix formatting issues.
🔇 Additional comments (7)
src/View.elm (1)
386-386: Add new font option to dropdown
TheTekitouPoemoption is correctly encoded and uses the localizedi18n.fgFontTekitouPoemlabel, matching the Elm model and CSS class.src/Model.elm (3)
52-52: AddTekitouPoemvariant
Introducing the new font variant in theFgFonttype. Downstream encode/decode functions are updated accordingly.
67-69: MapTekitouPoemto"tekitou-poem"
TheencodeFgFontcase now correctly returns"tekitou-poem", aligning with the CSS class and view logic.
79-79: IncludeTekitouPoemin decoding dictionary
UpdatingdictFgFontensuresdecodeFgFont "tekitou-poem"yieldsTekitouPoem.src/I18n.elm (3)
21-21: Add new localization field
TheLabelrecord now includesfgFontTekitouPoem, matching the new font variant.
47-47: Japanese label for TekitouPoem
The string"適当ポエム (手書き)"accurately conveys the handwriting style in Japanese.
73-73: English label for TekitouPoem
The string"Tekitou Poem (Handwriting)"is clear and consistent with other font labels.
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
|
@coderabbitai Update description. |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain@mather I'll update the PR description with a comprehensive summary of the changes. Let me first check the current description and then update it. 🏁 Script executed: Length of output: 815 🏁 Script executed: Length of output: 1631 @mather ✅ I've successfully updated the PR description with comprehensive details about the 「適当ポエム」font addition. The new description includes:
The description is now much more comprehensive and provides both technical details for developers and clear context about the feature addition. The original CodeRabbit summary has been preserved at the bottom for reference. 🐰✨ |
「適当ポエム」フォントの追加
このPRは、手書き風フォント「適当ポエム」をタイマーアプリに追加します。
概要
新しい手書き風フォント「Tekitou-Poem-SemiBold」を統合し、ユーザーがタイマーの前景フォントとして選択できるようになります。
変更内容
フォント追加
Tekitou-Poem-SemiBold.woff2技術的実装
CSS (
css/main.scss)@font-face宣言でフォントを読み込み.timer.tekitou-poemクラスでスタイル適用font-display: swapで読み込みパフォーマンスを最適化国際化対応 (
src/I18n.elm)データモデル (
src/Model.elm)FgFont型にTekitouPoemバリアントを追加UI (
src/View.elm)デバッグ強化 (
js/common.js)ユーザーへの影響
テスト
Deploy Preview: https://deploy-preview-116--sync-timer.netlify.app
Summary by CodeRabbit
New Features
Style
Bug Fixes
Chores