-
-
Notifications
You must be signed in to change notification settings - Fork 205
adding lots of tests for comparison #1200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mmatera Thanks! This helps a lot. I will look over and addresss this over the upcoming weekend. |
I plan also to add the same tests, but for inequalities |
|
@mmatera not that by issuing |
a188a4c to
86e274a
Compare
I made a push --force on this branch, sorry. Is it possible to undo that? Otherwise, please push your local branch again, and then I merge it with my local branch |
No problem. For pushed. Does it make sense why I suggest the rebase over the merge? |
|
@rocky, in this branch I made some changes in test/help.py to avoid some problems in the comparison of the expected and obtained results. The idea is that the output is passed through a |
OK, what I did is a merge in this branch from master. From which commit should I do a rebase? |
This is the process I did in order to try to remove duplicate changes to get a smaller set of changes to work with: Here is how you can get this branch as it is now saving your existing branch. |
fix duplicated DirectedInfinity entry clean and improved tests fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working
7b0b0da to
2472d6a
Compare
|
Well, here is the rebase. Also, I marked the non-working tests to be skipped. However, there are still a couple of doctests that are failing. I think that the bests would be to merge this branch after everything get fixed... |
fix duplicated DirectedInfinity entry restoring tests Fix Positive/Negative tests clean and working comment out debuggin prints
…into extensecmptests
|
@rocky: I am splitting these cases with this ugly framework because I want to understand the logic and where things go wrong. When I finish, I will try to comment line by line, and then, we can see how to improve this code. |
|
I close this in favor of #1209 |
@rocky , OK: you asked for tests, here you have tests :)