Implement undo/redo functionality #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Just tested this out and it seems to work well. It would be nice if the undo could remove created cells (i.e. results) but I don't think that should block this. Some undo/redo buttons might also be a nice addition. |
Contributor
Author
|
I've begun work on bringing the notebook interface up to date and have undo/redo buttons in the pipeline. Cell handling is a little harder but potentially doable; I'll see what can be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undo/redo functionality implementation for the web interface (refer #68).
The input cells are implemented using
textareaelements which have native browser undo/redo; however the specific way this works differs quite dramatically among browsers (e.g. Chrome vs. Firefox), and switching between cells can cause the undo history to be forgotten.A custom implementation is much better.
Tested on Firefox and Chrome; help testing on Safari appreciated.
Notes:
mathics.js.