Adds a cache for do_format #580
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poke1024
force-pushed
the
formatcache
branch
from
db6a0ab to
923723b
Compare
rocky
added a commit
that referenced
this pull request
Sep 29, 2020
Rebase Adds a cache for do_format (#580)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outputting parts of a list recomputes the format for everything each time an output happens.
Thus, outputting
x=Partition[Range[10000], 5],x,Drop[x]always callsdo_formaton each node of the whole tree.For XML data of a few KB
do_formatalone takes 1 to 2 s on my machine.This PR caches
do_formatfor trees and sub trees that were already output once. This depends on #575 as without it, a whole tree traversal is needed to check the cache, which invalidates the benefit.