Speedups by avoiding inner classes #616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sn6uv
reviewed
Oct 8, 2016
Member
sn6uv
left a comment
sn6uv
left a comment
There was a problem hiding this comment.
Looks good. I'm not sure about is_free though.
mathics/builtin/patterns.py
Outdated
| return True | ||
| else: | ||
| return expr.head.is_free(form, evaluation) and all( | ||
| leaf.is_free(form, evaluation) for leaf in expr.leaves) |
Member
There was a problem hiding this comment.
is this function related to the change?
Contributor
Author
There was a problem hiding this comment.
I forgot to hook this up. It's done now. I needed to move this function into patterns.py as the declaration of _StopGeneratorBaseExpressionIsFree needs StopGenerator which cannot be imported into core.expression.py as patterns.py depends on core.expression.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out that, at least in CPython, declaring
classes inside functions is quite slow.Running
x = Range[50000]; First[Timing[Position[x, 10000]]]without this PR gives1.16326, with this PR, it gives0.461211. This is only due to one innerclassdefinition.Running the profiler, one actually sees Python's class build function popping up. So this PR moves inner classes out of functions at several places.