In-memory sessions #623
Merged
In-memory sessions #623
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Maybe adding an autosave in idle time? |
Member
|
I guess this is a holdover from when we supported multiple client sessions properly in the frontend (I think it's somewhat broken now). The solution I envisage for multiple clients is to give each client their own kernel (or even multiple if they want different workspaces) and store all the definitions in memory. At idle time (or when we inevitably run out of RAM) the definitions should be saved to disk. When the user returns we load their state from disk. I'm +1 on merging this. |
Merged
Member
|
@poke1024 @GarkGarcia Although I did test this, please double check. If this is addressed it would be nice to close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm wondering if we really want to store definitions data in the database for the classic mathics server. If there's a lot of data, the interface gets really sluggish since it needs to unpickle and repickle all definitions for each query.
Here's a proposal to keep everything in memory, which is always fast (but loses its data, as soon as you quit the mathicsserver process).